table/tables: migrate test-infra to testify for tables_test.go#27902
table/tables: migrate test-infra to testify for tables_test.go#27902ti-chi-bot merged 31 commits intopingcap:masterfrom
tables_test.go#27902Conversation
This reverts commit aa63353.
Signed-off-by: tison <wander4096@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
/cc @tisonkun |
tisonkun
left a comment
There was a problem hiding this comment.
@feitian124 please resolve the conflict so that we can continue the review.
|
/run-check_dev_2 |
1 similar comment
|
/run-check_dev_2 |
|
should be ok, seems failed due to unstable test #27889 |
|
/cc @xhebox |
| defer func() { | ||
| _, err := ts.se.Execute(context.Background(), "DROP TABLE test.tRecord") | ||
| c.Assert(err, IsNil) | ||
| _, err := tk.Session().Execute(context.Background(), "DROP TABLE test.tRecord") | ||
| require.NoError(t, err) | ||
| }() |
There was a problem hiding this comment.
One thing I noticed is that we may be able to remove DROP TABLE, then cleanup function. Because every test is using a different mock store. You could investigate about that.
There was a problem hiding this comment.
create table -> do test -> drop table, it feels nature, the tests here are more like an integration tests.
it seems duplicated, but it also make sure drop table and clean up works.
There was a problem hiding this comment.
what's your idea?
if you insist on remove is better, i can do that job
There was a problem hiding this comment.
I won't insist anything as long as it is acceptable.
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 55595a0 |
|
@feitian124: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #27590, close #26866
based on #27812
notice:
table/tables/tables_test.go#27590 (comment)TestTableFromMetawas skipped before, enabled in this pr.Release note