Skip to content

tests: migrate test-infra to testify#27880

Merged
ti-chi-bot merged 15 commits intopingcap:masterfrom
ZipFast:migrate-test-for-tests
Sep 17, 2021
Merged

tests: migrate test-infra to testify#27880
ti-chi-bot merged 15 commits intopingcap:masterfrom
ZipFast:migrate-test-for-tests

Conversation

@ZipFast
Copy link
Contributor

@ZipFast ZipFast commented Sep 8, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #27874

Problem Summary: migrate test-infra to testify for tests folder

What is changed and how it works?

What's Changed: code in tests folder

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 8, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tisonkun
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 8, 2021
@CLAassistant
Copy link

CLAassistant commented Sep 8, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Sep 8, 2021
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 8, 2021
@ZipFast ZipFast force-pushed the migrate-test-for-tests branch 2 times, most recently from 41aa58c to d631e99 Compare September 8, 2021 07:12
@ZipFast ZipFast force-pushed the migrate-test-for-tests branch from 4571c44 to e5915a4 Compare September 8, 2021 11:46
@ZipFast ZipFast marked this pull request as ready for review September 13, 2021 09:12
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 13, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2021
@tisonkun
Copy link
Contributor

tisonkun commented Sep 16, 2021

Thanks a lot for your admirable work @Zwj-coder ! The next time you can try to request review by /cc @reviewer so that we can react on the pr more quickly.

@tisonkun
Copy link
Contributor

tisonkun commented Sep 16, 2021

/cc @xhebox

@ti-chi-bot ti-chi-bot requested a review from xhebox September 16, 2021 16:18
xhebox
xhebox reviewed Sep 17, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 17, 2021
@xhebox
Copy link
Contributor

xhebox commented Sep 17, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 17, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 4d62ea8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 17, 2021
@ti-chi-bot ti-chi-bot merged commit 9b0604b into pingcap:master Sep 17, 2021
@tisonkun
Copy link
Contributor

tisonkun commented Sep 17, 2021

@xhebox it seems we don't run these tests in PR tasks. I'll push a follow up for clean up some code for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@tisonkun tisonkun tisonkun approved these changes

@ichn-hu ichn-hu Awaiting requested review from ichn-hu

Assignees

No one assigned

Labels

component/test first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for tests folder

7 participants

@ZipFast @ti-chi-bot @CLAassistant @tisonkun @xhebox @ti-srebot @Relax4Life