Skip to content

*: fix the date race in TestCharsetFeature#27477

Merged
zhouqiang-cl merged 6 commits intopingcap:masterfrom
xiongjiwei:skip-test
Aug 23, 2021
Merged

*: fix the date race in TestCharsetFeature#27477
zhouqiang-cl merged 6 commits intopingcap:masterfrom
xiongjiwei:skip-test

Conversation

@xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Aug 23, 2021 •
edited by tisonkun
Loading

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2021
zimulala
zimulala approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 23, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Aug 23, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 23, 2021
@xiongjiwei
Copy link
Contributor Author

xiongjiwei commented Aug 23, 2021

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 23, 2021
@xiongjiwei xiongjiwei changed the title *: temporarily skip unstable test cases *: fix the date race in TestCharsetFeature Aug 23, 2021
@xiongjiwei xiongjiwei removed the status/LGT2 Indicates that a PR has LGTM 2. label Aug 23, 2021
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 23, 2021
@xiongjiwei
Copy link
Contributor Author

xiongjiwei commented Aug 23, 2021

/run-unit-test

@xiongjiwei
Copy link
Contributor Author

xiongjiwei commented Aug 23, 2021

/unhold

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 23, 2021
@xiongjiwei
Copy link
Contributor Author

xiongjiwei commented Aug 23, 2021

/run-unit-test

@tisonkun
Copy link
Contributor

tisonkun commented Aug 23, 2021 •
edited
Loading

@zimulala @xhebox @bb7133 I think one of you should comment /merge for merging this fix.

@zimulala
Copy link
Contributor

zimulala commented Aug 23, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 52db181

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2021
@xiongjiwei
Copy link
Contributor Author

xiongjiwei commented Aug 23, 2021

/run-unit-test

@xiongjiwei
Copy link
Contributor Author

xiongjiwei commented Aug 23, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2021

@xiongjiwei: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2021

@xiongjiwei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

1 similar comment
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2021

@xiongjiwei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zhouqiang-cl zhouqiang-cl merged commit 002318f into pingcap:master Aug 23, 2021
@xiongjiwei xiongjiwei deleted the skip-test branch October 11, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@zimulala zimulala zimulala approved these changes

@xhebox xhebox xhebox approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

data race in executor_test testSerialSuite2).TestCharsetFeature data race in executor/executor_test.go data race in util/collate/collate.go

7 participants

@xiongjiwei @ti-chi-bot @tisonkun @zimulala @bb7133 @xhebox @zhouqiang-cl