Skip to content

slow_query: cancel send taskList if ctx is done#27471

Merged
zhouqiang-cl merged 3 commits intopingcap:masterfrom
tisonkun:issue-27437
Aug 23, 2021
Merged

slow_query: cancel send taskList if ctx is done#27471
zhouqiang-cl merged 3 commits intopingcap:masterfrom
tisonkun:issue-27437

Conversation

@tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Aug 22, 2021 •
edited by bb7133
Loading

Signed-off-by: tison wander4096@gmail.com

What problem does this PR solve?

Issue Number: close #27437 , close #27475

Release note

None

@tisonkun
slow_query: cancel send taskList if ctx is done
5a582d5 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 22, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • crazycs520

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2021
@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 22, 2021

/run-check_dev_2

@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 22, 2021

/cc @djshow832 @crazycs520

@tisonkun tisonkun mentioned this pull request Aug 22, 2021
Merged
@tisonkun
empty to retrigger ci
c67a655 
Signed-off-by: tison <wander4096@gmail.com>
@github-actions github-actions bot added the sig/execution SIG execution label Aug 22, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 23, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 23, 2021
@bb7133
Copy link
Member

bb7133 commented Aug 23, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2021

@bb7133: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 23, 2021

/run-unit-test

@bb7133 bb7133 removed the sig/execution SIG execution label Aug 23, 2021
@bb7133
Copy link
Member

bb7133 commented Aug 23, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 89a1d6d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2021
@bb7133
Copy link
Member

bb7133 commented Aug 23, 2021

/run-unit-test

@zhouqiang-cl zhouqiang-cl merged commit 529fc03 into pingcap:master Aug 23, 2021
@tisonkun tisonkun deleted the issue-27437 branch August 23, 2021 04:15
This was referenced Aug 23, 2021
Merged
Merged
@djshow832 djshow832 mentioned this pull request Feb 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@djshow832 djshow832 Awaiting requested review from djshow832

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Leak in executor.(*slowQueryRetriever).parseSlowLog Leak tests pkg executor github.com/pingcap/tidb/executor.(*slowQueryRetriever).parseSlowLog

5 participants

@tisonkun @ti-chi-bot @bb7133 @crazycs520 @zhouqiang-cl