Skip to content

planner: fix some unstable prepare-cache test cases#27335

Merged
ti-chi-bot merged 6 commits intopingcap:masterfrom
qw4990:fix-unstable-prepare-test
Aug 18, 2021
Merged

planner: fix some unstable prepare-cache test cases#27335
ti-chi-bot merged 6 commits intopingcap:masterfrom
qw4990:fix-unstable-prepare-test

Conversation

@qw4990
Copy link
Contributor

@qw4990 qw4990 commented Aug 18, 2021

What problem does this PR solve?

Issue Number: close #25459, close #25692, close #25455

Problem Summary: planner: fix some unstable prepare-cache test cases

What is changed and how it works?

These goroutine leak problems are probably fixed by #26500, so open them again.

Check List

Tests

  • Unit test

Release note 

None

@qw4990 qw4990 added the sig/planner SIG: Planner label Aug 18, 2021
@qw4990 qw4990 requested review from Reminiscent and rebelice August 18, 2021 08:25
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 18, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 18, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 18, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 18, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 18, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: e074a16

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 18, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 18, 2021

@qw4990: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 18, 2021

/merge

@ichn-hu ichn-hu mentioned this pull request Aug 18, 2021
Closed
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 18, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit b301e1a into pingcap:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rebelice rebelice rebelice approved these changes

+1 more reviewer

@Reminiscent Reminiscent Reminiscent approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

4 participants

@qw4990 @ti-chi-bot @rebelice @Reminiscent