Skip to content

planner/cascades: migrate test-infra to testify #27277

Merged
ti-chi-bot merged 9 commits intopingcap:masterfrom
tisonkun:issue-26856
Aug 19, 2021
Merged

planner/cascades: migrate test-infra to testify #27277
ti-chi-bot merged 9 commits intopingcap:masterfrom
tisonkun:issue-26856

Conversation

@tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Aug 17, 2021

What problem does this PR solve?

Issue Number: close #26856

Release note

None

@tisonkun
planner/cascades: migrate test-inra to testify
891886d 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
migrate integration_test.go
08e9b9f 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 17, 2021
@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 17, 2021 •
edited
Loading

/uncc @winoros
/cc @francis0407

@ti-chi-bot ti-chi-bot removed the request for review from winoros August 17, 2021 03:42
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 17, 2021

@tisonkun: GitHub didn't allow me to request PR reviews from the following users: mmyj, francis0407.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/uncc @winoros
/cc @mmyj @francis0407

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the sig/planner SIG: Planner label Aug 17, 2021
@tisonkun tisonkun requested a review from time-and-fate August 18, 2021 09:22
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 19, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 19, 2021
@Reminiscent
Copy link
Contributor

Reminiscent commented Aug 19, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 19, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7a78524

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 19, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 19, 2021

@tisonkun: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 19, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 19, 2021

@tisonkun: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit dfe9acf into pingcap:master Aug 19, 2021
@tisonkun tisonkun mentioned this pull request Sep 2, 2021
Merged
1 task
@tisonkun tisonkun mentioned this pull request Feb 6, 2022
Merged
12 tasks
@tisonkun tisonkun deleted the issue-26856 branch March 4, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

+1 more reviewer

@Reminiscent Reminiscent Reminiscent approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for planner/cascades

4 participants

@tisonkun @ti-chi-bot @Reminiscent @time-and-fate