Skip to content

distsql/request_builder_test: migrate test-infra to testify#27068

Merged
ti-chi-bot merged 6 commits intopingcap:masterfrom
tomatopunk:undesign-distsql-request-build-test
Aug 12, 2021
Merged

distsql/request_builder_test: migrate test-infra to testify#27068
ti-chi-bot merged 6 commits intopingcap:masterfrom
tomatopunk:undesign-distsql-request-build-test

Conversation

@tomatopunk
Copy link
Contributor

@tomatopunk tomatopunk commented Aug 10, 2021

What problem does this PR solve?

Issue Number: close #26156
Based on: #26809

I push this PR early to get more comments on the refactor part. t

Split from folder distsql test

  • distsql/select_result_test (merged)
  • distsql/distsql_test
  • distsql/request_build_test

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 10, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mmyj
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 10, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Aug 10, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 11, 2021
tisonkun
tisonkun reviewed Aug 11, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

@tisonkun
Copy link
Contributor

tisonkun commented Aug 12, 2021

/cc @xhebox @mmyj @djshow832
PTAL

@ti-chi-bot ti-chi-bot requested review from djshow832 and xhebox August 12, 2021 01:34
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 12, 2021

@tisonkun: GitHub didn't allow me to request PR reviews from the following users: mmyj.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @xhebox @mmyj @djshow832
PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 12, 2021
mmyj
mmyj approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@mmyj mmyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 12, 2021
@mmyj
Copy link
Member

mmyj commented Aug 12, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 12, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 735a704

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 12, 2021
@tomatopunk
Copy link
Contributor Author

tomatopunk commented Aug 12, 2021

/run-all-tests

@mmyj
Copy link
Member

mmyj commented Aug 12, 2021

/run-all-tests

CI can not work now. Someone will fix it soon.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 12, 2021

@tomatopunk: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit fcd3ff7 into pingcap:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tisonkun tisonkun tisonkun left review comments

@xhebox xhebox xhebox approved these changes

@mmyj mmyj mmyj approved these changes

@djshow832 djshow832 Awaiting requested review from djshow832

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. sig/execution SIG execution size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for distsql pkg

5 participants

@tomatopunk @ti-chi-bot @tisonkun @mmyj @xhebox