Skip to content

parser: disable text position recording#27009

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
tangenta:parser-disable-pos
Aug 9, 2021
Merged

parser: disable text position recording#27009
ti-chi-bot merged 3 commits intopingcap:masterfrom
tangenta:parser-disable-pos

Conversation

@tangenta
Copy link
Contributor

@tangenta tangenta commented Aug 9, 2021

What problem does this PR solve?

Issue Number: close #26538

Problem Summary: For details, see #26538 (comment)

What is changed and how it works?

NA

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 9, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • crazycs520
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 9, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 9, 2021
@tangenta
Copy link
Contributor Author

tangenta commented Aug 9, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 9, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 859c210

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 9, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 9, 2021
@tangenta
Copy link
Contributor Author

tangenta commented Aug 9, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 9, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 4902d36

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 9, 2021
@tangenta
Copy link
Contributor Author

tangenta commented Aug 9, 2021

/build

@ti-chi-bot ti-chi-bot merged commit bd7e3ae into pingcap:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

data race in github.com/pingcap/parser/ast.(*node).SetOriginTextPosition()

4 participants

@tangenta @ti-chi-bot @tiancaiamao @crazycs520