Skip to content

planner/implementation: migrate test-infra to testify#26910

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
yedamao:issue-26858
Aug 9, 2021
Merged

planner/implementation: migrate test-infra to testify#26910
ti-chi-bot merged 3 commits intopingcap:masterfrom
yedamao:issue-26858

Conversation

@yedamao
Copy link
Contributor

@yedamao yedamao commented Aug 5, 2021

What problem does this PR solve?

Issue Number: close #26858

Release note 

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 5, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rebelice
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 6, 2021

@tisonkun: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tisonkun
Copy link
Contributor

tisonkun commented Aug 6, 2021

Thanks for your contribution!

/cc @xhebox @rebelice

PTAL

@ti-chi-bot ti-chi-bot requested review from rebelice and xhebox August 6, 2021 13:09
xhebox
xhebox approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a planner reviewer though.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 6, 2021
@tisonkun
Copy link
Contributor

tisonkun commented Aug 6, 2021

Not a planner reviewer though.

I notify you since there is no sig/planner label, weird but we can move forward （x)

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 9, 2021
@rebelice
Copy link
Contributor

rebelice commented Aug 9, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 9, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7e1a33b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 9, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 9, 2021

@yedamao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 880c9b5 into pingcap:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@tisonkun tisonkun tisonkun approved these changes

@rebelice rebelice rebelice approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for planner/implementation

5 participants

@yedamao @ti-chi-bot @tisonkun @rebelice @xhebox