Skip to content

server, test: add missing TearDownSuite()#26891

Merged
ti-chi-bot merged 2 commits intopingcap:masterfrom
bb7133:bb7133/fix_25458
Aug 4, 2021
Merged

server, test: add missing TearDownSuite()#26891
ti-chi-bot merged 2 commits intopingcap:masterfrom
bb7133:bb7133/fix_25458

Conversation

@bb7133
Copy link
Member

@bb7133 bb7133 commented Aug 4, 2021

What problem does this PR solve?

Issue Number: close #25458

Problem Summary:

What is changed and how it works?

How it Works: TBA

Check List

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 4, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • crazycs520
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 4, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Aug 4, 2021
@bb7133 bb7133 requested review from crazycs520 and glorv and removed request for crazycs520 August 4, 2021 07:19
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 4, 2021
@xiongjiwei
Copy link
Contributor

xiongjiwei commented Aug 4, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 4, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 079c3dc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 4, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 4, 2021

@bb7133: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 15ca386 into pingcap:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@tangenta tangenta tangenta approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@glorv glorv Awaiting requested review from glorv

+1 more reviewer

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. sig/sql-infra SIG: SQL Infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unstable test ConnTestSuite.TearDownSuite

6 participants

@bb7133 @ti-chi-bot @xiongjiwei @wjhuang2016 @tangenta @crazycs520