Skip to content

planner: fix the unstable test case TestListPartitionOrderLimit#26839

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
qw4990:fix-26796
Aug 3, 2021
Merged

planner: fix the unstable test case TestListPartitionOrderLimit#26839
ti-chi-bot merged 3 commits intopingcap:masterfrom
qw4990:fix-26796

Conversation

@qw4990
Copy link
Contributor

@qw4990 qw4990 commented Aug 3, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #26796

Problem Summary: planner: fix the unstable test case TestListPartitionOrderLimit

What is changed and how it works?

To make the test query select * from t order by c limit 5 stable, values on c cannot be duplicated.

Check List

Tests

  • Unit test

Release note

planner: fix the unstable test case TestListPartitionOrderLimit

@qw4990 qw4990 added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Aug 3, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2021

@qw4990: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 3, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 3, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 3, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: ac88580913938634aa8978daa43e73b12ce8e8f8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 3, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 0d2069c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 3, 2021

/merge

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 3, 2021

/merge

@qw4990 qw4990 mentioned this pull request Aug 3, 2021
Merged
1 task
@qw4990 qw4990 removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 3, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 3, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 884a838 into pingcap:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

+1 more reviewer

@Reminiscent Reminiscent Reminiscent approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unstable test testIntegrationPartitionSerialSuite.TestListPartitionOrderLimit

4 participants

@qw4990 @ti-chi-bot @time-and-fate @Reminiscent