Skip to content

util: fix unstale TestHeapProfileRecorder#26542

Merged
ti-chi-bot merged 2 commits intopingcap:masterfrom
Yisaer:fix_heap_test
Jul 30, 2021
Merged

util: fix unstale TestHeapProfileRecorder#26542
ti-chi-bot merged 2 commits intopingcap:masterfrom
Yisaer:fix_heap_test

Conversation

@Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Jul 26, 2021

Signed-off-by: yisaer disxiaofei@163.com

What problem does this PR solve?

Issue Number: close #26099

Problem Summary:

TestHeapProfileRecorder is not stale in unit test

What is changed and how it works?

Proposal: xxx

What's Changed:

Fix unstale test

How it Works:

Check List

Tests

  • Unit test

Release note

  • No release note

@Yisaer
address the comment
688af4d 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 26, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 26, 2021
xhebox
xhebox reviewed Jul 26, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any explanation on why it fixed the problem?

@Yisaer
Copy link
Contributor Author

Yisaer commented Jul 30, 2021

Any explanation on why it fixed the problem?

visit the lru after the profile in order not to being gc which cause unit test unstable.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 30, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 30, 2021
@Yisaer
Copy link
Contributor Author

Yisaer commented Jul 30, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 30, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 688af4d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 30, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 30, 2021

@Yisaer: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 9334324 into pingcap:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

+1 more reviewer

@lhy1024 lhy1024 lhy1024 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unstable test: trackerrecorder_test.go:63: trackRecorderSuite.TestHeapProfileRecorder

4 participants

@Yisaer @ti-chi-bot @xhebox @lhy1024