Skip to content

types/driver: migrate test-infra to testify#26522

Merged
ti-chi-bot merged 2 commits intopingcap:masterfrom
tisonkun:issue-26521
Jul 27, 2021
Merged

types/driver: migrate test-infra to testify#26522
ti-chi-bot merged 2 commits intopingcap:masterfrom
tisonkun:issue-26521

Conversation

@tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Jul 23, 2021

Signed-off-by: tison wander4096@gmail.com

What problem does this PR solve?

Issue Number: close #26521

Release note

  • No release note

@tisonkun
types/driver: migrate test-infra to testify
b494003 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 23, 2021
@tisonkun tisonkun requested review from tiancaiamao and xhebox July 23, 2021 15:46
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2021
@tisonkun tisonkun requested a review from tangenta July 27, 2021 02:54
@tisonkun
Copy link
Contributor Author

tisonkun commented Jul 27, 2021

/cc @mmyj

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2021

@tisonkun: GitHub didn't allow me to request PR reviews from the following users: mmyj.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @mmyj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mmyj
mmyj approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@mmyj mmyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mmyj
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 27, 2021
@mmyj
Copy link
Member

mmyj commented Jul 27, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b494003

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 27, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2021

@tisonkun: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 3642e87 into pingcap:master Jul 27, 2021
@tisonkun tisonkun deleted the issue-26521 branch March 4, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@mmyj mmyj mmyj approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@tangenta tangenta Awaiting requested review from tangenta

Assignees

No one assigned

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for types/driver pkg

4 participants

@tisonkun @ti-chi-bot @mmyj @xhebox