Skip to content

util: fix leak checking#26514

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
wjhuang2016:fix_leak
Jul 25, 2021
Merged

util: fix leak checking#26514
ti-chi-bot merged 4 commits intopingcap:masterfrom
wjhuang2016:fix_leak

Conversation

@wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Jul 23, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #25589, close #25640

Problem Summary:
After we change ddl.start() to ddl.Start(), the ignoreList doesn't work any longer.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

  • No release note

@wjhuang2016
done
6e67afd 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2021
@ichn-hu ichn-hu mentioned this pull request Jul 23, 2021
Closed
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 24, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 24, 2021
@bb7133
Copy link
Member

bb7133 commented Jul 24, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 24, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 6e67afd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 24, 2021
@zhouqiang-cl
Copy link
Contributor

zhouqiang-cl commented Jul 25, 2021

/rebuild

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 25, 2021

@wjhuang2016: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit c7e0e53 into pingcap:master Jul 25, 2021
This was referenced Aug 3, 2021
Closed
Closed
@wjhuang2016 wjhuang2016 deleted the fix_leak branch November 17, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@xhebox xhebox xhebox approved these changes

Assignees

No one assigned

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unstable test testPrepareSerialSuite.TestConstPropAndPPDWithCache Unstable test testPrepareSerialSuite.TestPrepareOverMaxPreparedStmtCount

5 participants

@wjhuang2016 @ti-chi-bot @bb7133 @zhouqiang-cl @xhebox