Skip to content

planner: fix goroutine leak problem in some unit tests (#26500)#26506

Merged
ti-chi-bot merged 4 commits intopingcap:release-5.1from
ti-srebot:release-5.1-591ebdd92636
Sep 16, 2021
Merged

planner: fix goroutine leak problem in some unit tests (#26500)#26506
ti-chi-bot merged 4 commits intopingcap:release-5.1from
ti-srebot:release-5.1-591ebdd92636

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 23, 2021 •
edited
Loading

cherry-pick #26500 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/26506

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/26506:release-5.1-591ebdd92636

What problem does this PR solve?

Issue Number: close #25014, #25190

Problem Summary: planner: fix goroutine leak problem in some unit tests

What is changed and how it works?

planner: fix goroutine leak problem in some unit tests

Check List

Tests

  • Unit test

Release note

  • No release note

@qw4990 @ti-srebot
cherry pick pingcap#26500 to release-5.1
26178f0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner July 23, 2021 07:01
@ti-srebot ti-srebot requested review from time-and-fate and removed request for a team July 23, 2021 07:01
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jul 23, 2021

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Jul 23, 2021
Merged
1 task
@ti-srebot ti-srebot added sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.1-cherry-pick type/bugfix This PR fixes a bug. labels Jul 23, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jul 23, 2021

@qw4990 you're already a collaborator in bot's repo.

@wjhuang2016 wjhuang2016 reopened this Jul 23, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 26, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 4, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 16, 2021
@zhouqiang-cl
Copy link
Contributor

zhouqiang-cl commented Sep 16, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 16, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: ab86672

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 16, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 16, 2021

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 1cae2c5 into pingcap:release-5.1 Sep 16, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.4, v5.1.2 Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

@winoros winoros Awaiting requested review from winoros

+1 more reviewer

@Reminiscent Reminiscent Reminiscent approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@qw4990 qw4990

Labels

cherry-pick-approved Cherry pick PR approved by release team. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.1-cherry-pick

Projects

None yet

Milestone

v5.1.2

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-srebot @ti-chi-bot @zhouqiang-cl @wjhuang2016 @Reminiscent @qw4990