Skip to content

util/tracing: migrate tracing test to testify#26448

Merged
ti-chi-bot merged 2 commits intopingcap:masterfrom
mosqd:migrate-util-tracing-tests
Jul 22, 2021
Merged

util/tracing: migrate tracing test to testify#26448
ti-chi-bot merged 2 commits intopingcap:masterfrom
mosqd:migrate-util-tracing-tests

Conversation

@mosqd
Copy link
Contributor

@mosqd mosqd commented Jul 21, 2021

What problem does this PR solve?

Issue Number: close #26429

What's Changed:

migrate tracing test to testify

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 21, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 21, 2021

Welcome @mosqd!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@mosqd
Copy link
Contributor Author

mosqd commented Jul 22, 2021

/cc @tisonkun @morgo @xhebox

@ti-chi-bot ti-chi-bot requested review from morgo, tisonkun and xhebox July 22, 2021 02:54
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 22, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 22, 2021
@morgo
Copy link
Contributor

morgo commented Jul 22, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 22, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 1dd0ca3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 22, 2021
@ti-chi-bot ti-chi-bot merged commit 1a3fddc into pingcap:master Jul 22, 2021
@mosqd mosqd deleted the migrate-util-tracing-tests branch July 22, 2021 04:20
@zhouqiang-cl zhouqiang-cl mentioned this pull request Jul 22, 2021
Closed
@tisonkun tisonkun removed their request for review July 31, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morgo morgo morgo approved these changes

@xhebox xhebox xhebox approved these changes

Assignees

No one assigned

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for util/tracing pkg

4 participants

@mosqd @ti-chi-bot @morgo @xhebox