server: fix test for clienterrors#25278
Conversation
xhebox
left a comment
There was a problem hiding this comment.
Reasonable to me. And we can always reopen the issue if it is not fixed.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 8e54328 |
|
@morgo: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #25056 and close #23977
Problem Summary:
In all known cases of this test failure, it is on checking that the warning count is correct, and not the error count.
I believe the root cause is because clienterrrors is populated on the network send event, and because the result set was not explicitly read (and there is one in the event of a warning) it's possible that the warning count had not been updated yet.
The fixed code makes a deliberate attempt to read the data into a fake string, but do nothing with it.
What is changed and how it works?
What's Changed:
Improved test stability (flaky test)
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note