*: use pprof profile to collect CPU time group by SQL and plan digest#24892
Merged
ti-chi-bot merged 67 commits intopingcap:masterfrom Jun 2, 2021
Merged
*: use pprof profile to collect CPU time group by SQL and plan digest#24892ti-chi-bot merged 67 commits intopingcap:masterfrom
ti-chi-bot merged 67 commits intopingcap:masterfrom
Conversation
Signed-off-by: crazycs <chen.two.cs@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Contributor
Author
|
/run-all-tests |
Signed-off-by: crazycs <crazycs520@gmail.com>
breezewish
reviewed
Jun 1, 2021
breezewish
reviewed
Jun 1, 2021
Signed-off-by: crazycs <crazycs520@gmail.com>
Co-authored-by: Wenxuan <hi@breeswish.org>
Signed-off-by: crazycs <crazycs520@gmail.com>
Contributor
Author
|
/run-all-tests |
1 similar comment
Contributor
Author
|
/run-all-tests |
breezewish
approved these changes
Jun 1, 2021
Member
|
/run-all-tests |
Contributor
Author
|
/run-common-test |
Contributor
Author
|
/run-common-test |
1 similar comment
Contributor
Author
|
/run-common-test |
Contributor
Author
|
/run-common-test |
Contributor
Author
|
/run-common-test tidb-test=master |
tiancaiamao
approved these changes
Jun 2, 2021
Contributor
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/build |
Contributor
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
Contributor
Author
|
/run-check_release_note |
Contributor
Author
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 75e8d94 |
Contributor
Author
|
/merge |
|
Hi
Thank you for your excellent services!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track issue: #24875
What problem does this PR solve?
This PR uses
pprof profile labelsto collect CPU time group by SQL and plan digest.What is changed and how it works?
The implementation is:
1: Use SQL digest and plan digest as the pprof labels.
There is a special case, for
execute stmtSQL, should use the prepare SQL digest as thesql_digestpprof label.Using a buffer channel to avoid parse and output take too much time that infect the fetching profile work.
Other problem
Because the
profile workerkeep callingpprof.StartCPUProfileto fetch profile data, other place (such pprof profile HTTP API handler) callpprof.StartCPUProfilewill be failed.In order to solve this problem, other place should fetch profile data from
profile workerinstead ofpprof.StartCPUProfile.Check List
Tests
Side effects
Release note