Skip to content

executor: add table name in log (#24666)#24802

Merged
ti-chi-bot merged 5 commits intopingcap:release-5.0from
ti-srebot:release-5.0-013b3f1f498d
Aug 12, 2021
Merged

executor: add table name in log (#24666)#24802
ti-chi-bot merged 5 commits intopingcap:release-5.0from
ti-srebot:release-5.0-013b3f1f498d

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented May 20, 2021 •
edited
Loading

cherry-pick #24666 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24802

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/24802:release-5.0-013b3f1f498d

What problem does this PR solve?

Issue Number: related to #24643

Problem Summary:

What is changed and how it works?

What's Changed:
Only add table name in log.

How it Works:
Got table name in partition-table's metadata and output it.

Check List

Tests

  • Unit test

Release note

  • add table name in log

@ti-srebot
cherry pick pingcap#24666 to release-5.0
ebf0806 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner May 20, 2021 10:35
@ti-srebot ti-srebot requested review from XuHuaiyu and removed request for a team May 20, 2021 10:35
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 20, 2021

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /merge) by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented May 20, 2021

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request May 20, 2021
Merged
@ti-srebot ti-srebot added sig/execution SIG execution size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.0-cherry-pick labels May 20, 2021
@ti-srebot ti-srebot added this to the v5.0.1 milestone May 20, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented May 20, 2021

@AilinKid you're already a collaborator in bot's repo.

@wjhuang2016
Copy link
Member

wjhuang2016 commented May 21, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 21, 2021
@AilinKid
Copy link
Contributor

AilinKid commented May 25, 2021

/lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 25, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 25, 2021
@wjhuang2016
Copy link
Member

wjhuang2016 commented May 25, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 25, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: ebf0806

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2021
@wjhuang2016 wjhuang2016 removed their request for review June 2, 2021 07:40
@guo-shaoge guo-shaoge removed the request for review from XuHuaiyu June 10, 2021 02:09
@qw4990
Copy link
Contributor

qw4990 commented Jun 23, 2021

/merge

@qw4990
Copy link
Contributor

qw4990 commented Jun 24, 2021

/merge

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 12, 2021
@zhouqiang-cl
Copy link
Contributor

zhouqiang-cl commented Aug 12, 2021

@ti-chi-bot

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 12, 2021

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 210764b into pingcap:release-5.0 Aug 12, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.1, v5.0.4 Sep 10, 2021
@djshow832 djshow832 mentioned this pull request Sep 15, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees

@AilinKid AilinKid

Labels

cherry-pick-approved Cherry pick PR approved by release team. sig/execution SIG execution size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick

Projects

None yet

Milestone

v5.0.4

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-srebot @ti-chi-bot @wjhuang2016 @AilinKid @qw4990 @zhouqiang-cl