Skip to content

expression: support cast real/int as real (#24670)#24801

Closed
ti-srebot wants to merge 1 commit intopingcap:release-5.0from
ti-srebot:release-5.0-5be8a6563399
Closed

expression: support cast real/int as real (#24670)#24801
ti-srebot wants to merge 1 commit intopingcap:release-5.0from
ti-srebot:release-5.0-5be8a6563399

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented May 20, 2021 •
edited
Loading

cherry-pick #24670 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24801

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/24801:release-5.0-5be8a6563399

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: support cast int/real as real being pushed down to tiflash

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • support cast int/real as real being pushed down to tiflash

@fzhedu @ti-srebot
cherry pick pingcap#24670 to release-5.0
ec8566d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 20, 2021

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-srebot ti-srebot requested review from a team as code owners May 20, 2021 10:01
@ti-srebot ti-srebot requested review from lzmhhh123 and removed request for a team May 20, 2021 10:01
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 20, 2021

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /merge) by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented May 20, 2021

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request May 20, 2021
Merged
@ti-srebot ti-srebot added component/expression size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.0-cherry-pick labels May 20, 2021
@ti-srebot ti-srebot requested review from hanfei1991 and rebelice May 20, 2021 10:01
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2021
@ti-srebot ti-srebot added this to the v5.0.1 milestone May 20, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented May 20, 2021

@fzhedu you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 19, 2021

@ti-srebot: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@winoros
Copy link
Member

winoros commented Jun 21, 2021

Please fix the conflicts then re-request review

@winoros winoros removed request for a team and rebelice June 21, 2021 07:09
@lzmhhh123 lzmhhh123 removed their request for review June 28, 2021 02:39
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 30, 2021
@XuHuaiyu XuHuaiyu closed this Sep 2, 2021
@zhouqiang-cl zhouqiang-cl removed the cherry-pick-approved Cherry pick PR approved by release team. label Sep 3, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 3, 2021

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees

@fzhedu fzhedu

Labels

component/expression do-not-merge/cherry-pick-not-approved needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.0-cherry-pick

Projects

None yet

Milestone

v5.0.1

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-srebot @ti-chi-bot @winoros @fzhedu @XuHuaiyu @zhouqiang-cl