Skip to content

cmd: ddl_test modify retryCnt from 5 to 20 (#24662)#24664

Closed
ti-srebot wants to merge 2 commits intopingcap:release-5.0from
ti-srebot:release-5.0-392df99f04d5
Closed

cmd: ddl_test modify retryCnt from 5 to 20 (#24662)#24664
ti-srebot wants to merge 2 commits intopingcap:release-5.0from
ti-srebot:release-5.0-392df99f04d5

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented May 14, 2021 •
edited
Loading

cherry-pick #24662 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24664

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/24664:release-5.0-392df99f04d5

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

What's Changed:
When the CI is unstable, tidb-server may take a long time to start. This will cause the ping to fail.
When reaching the retryCnt the integration-dll-test will fatal.

This commit increases the retryCnt to 20 to reduce the impact of the unstable CI.

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • No code

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • No release note

@XuHuaiyu @ti-srebot
cherry pick pingcap#24662 to release-5.0
b0c0f48 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 14, 2021

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /merge) by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented May 14, 2021

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request May 14, 2021
Merged
@ti-srebot ti-srebot added component/test sig/sql-infra SIG: SQL Infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.0-cherry-pick labels May 14, 2021
@ti-srebot ti-srebot requested a review from AilinKid May 14, 2021 09:22
@ti-srebot ti-srebot added this to the v5.0.1 milestone May 14, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented May 14, 2021

@XuHuaiyu you're already a collaborator in bot's repo.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 23, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 12, 2021
zimulala
zimulala approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 16, 2021
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Dec 16, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 16, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b0c0f48

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 16, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 16, 2021

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@XuHuaiyu XuHuaiyu closed this Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimulala zimulala zimulala approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees

@XuHuaiyu XuHuaiyu

Labels

cherry-pick-approved Cherry pick PR approved by release team. component/test sig/sql-infra SIG: SQL Infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick

Projects

None yet

Milestone

v5.0.1

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-srebot @ti-chi-bot @XuHuaiyu @zimulala @AilinKid @zhouqiang-cl