server: close the temporary session in HTTP API to avoid memory leak (#24339)#24650
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved ( AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/run-all-tests |
|
@tiancaiamao you're already a collaborator in bot's repo. |
|
/lgtm |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by writing |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 13554ca |
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #24339 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/24650After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
In one of our customer we find their TiDB memory usage is abnormal:
And the inused object is
SessionStatsCollectorwhich is allocated from the HTTP API:Problem Summary:
What is changed and how it works?
The
SessionStatsCollectoris used by each session to collect its statistics changes, and merge the change with feedback and dump to TiKV.All stats collector are linked together in the statistics handler which is a global object. As it's referenced, Go GC can not release them and that result in the memory leak.
What's Changed:
Do not allocate the
SessionStatsCollectorfor the session object in HTTP handler.How it Works:
Related changes
Check List
Tests
Release note