Skip to content

planner/core: refresh stale regions in cache for batch cop response (#24457)#24612

Closed
ti-srebot wants to merge 1 commit intopingcap:release-5.0from
ti-srebot:release-5.0-956149cdbb83
Closed

planner/core: refresh stale regions in cache for batch cop response (#24457)#24612
ti-srebot wants to merge 1 commit intopingcap:release-5.0from
ti-srebot:release-5.0-956149cdbb83

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented May 13, 2021 •
edited
Loading

cherry-pick #24457 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24612

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/24612:release-5.0-956149cdbb83

What problem does this PR solve?

Issue Number: close pingcap/tiflash#1873

What is changed and how it works?

What's Changed:
add retry regions in Batch cop response. then refresh the stale regions in cache.

Related changes

pingcap/kvproto#761

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

  • planner/core: refresh stale regions in cache for batch cop response

@hanfei1991 @ti-srebot
cherry pick pingcap#24457 to release-5.0
22e98e2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 13, 2021

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 13, 2021

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /merge) by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented May 13, 2021

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request May 13, 2021
Merged
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.0-cherry-pick labels May 13, 2021
@ti-srebot ti-srebot requested a review from lzmhhh123 May 13, 2021 05:36
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2021
@ti-srebot ti-srebot added this to the v5.0.1 milestone May 13, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented May 13, 2021

@hanfei1991 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 29, 2021

@ti-srebot: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hanfei1991 hanfei1991 closed this Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees

@hanfei1991 hanfei1991

Labels

do-not-merge/cherry-pick-not-approved needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/5.0-cherry-pick

Projects

None yet

Milestone

v5.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-srebot @ti-chi-bot @hanfei1991