Skip to content

store/tikv: batch regions in a single scatter request#24593

Closed
rleungx wants to merge 1 commit intopingcap:masterfrom
rleungx:batch-scatter
Closed

store/tikv: batch regions in a single scatter request#24593
rleungx wants to merge 1 commit intopingcap:masterfrom
rleungx:batch-scatter

Conversation

@rleungx
Copy link
Member

@rleungx rleungx commented May 12, 2021 •
edited
Loading

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Problem Summary: For now, we call ScatterRegions for every single region.

What is changed and how it works?

What's Changed: This PR supports sending multi regions in a single request.

Check List

Tests

  • Unit test

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 12, 2021
@rleungx
Copy link
Member Author

rleungx commented May 12, 2021

/cc @Yisaer

@ti-chi-bot ti-chi-bot requested a review from Yisaer May 12, 2021 10:51
@rleungx
batch scatter region in a single request
ca6dc40 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Yisaer
Yisaer approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 14, 2021
@rleungx
Copy link
Member Author

rleungx commented May 17, 2021

/cc @nolouch

@ti-chi-bot ti-chi-bot requested a review from nolouch May 17, 2021 09:26
nolouch
nolouch approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 3, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 3, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 12, 2021

@rleungx: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tisonkun
Copy link
Contributor

tisonkun commented Jul 14, 2021

@rleungx may this PR goes to client-go? I think there is no store/tikv now.

@rleungx
Copy link
Member Author

rleungx commented Jul 14, 2021

Close it since the corresponding code has moved to client-go repo.

@rleungx rleungx closed this Jul 14, 2021
@sylzd sylzd mentioned this pull request Jul 26, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nolouch nolouch nolouch approved these changes

+1 more reviewer

@Yisaer Yisaer Yisaer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rleungx @ti-chi-bot @tisonkun @nolouch @Yisaer