*: support read and write operations for the global temporary table#24196
*: support read and write operations for the global temporary table#24196ti-chi-bot merged 19 commits intopingcap:masterfrom
Conversation
|
/rebuild |
|
/run-check_dev_2 This CI is quite unstable currently. |
3667d43 to
0e52f9e
Compare
| }() | ||
| // Set the limitation to a small value, make it easier to reach the limitation. | ||
| atomic.StoreUint64(&kv.TxnTotalSizeLimit, 5000) | ||
| atomic.StoreUint64(&kv.TxnTotalSizeLimit, 5500) |
There was a problem hiding this comment.
This change is because we update the parser, and marshal table info use more bytes (add a new temporary field, now it's 5038 byte).
If I don't change here, CI will fail and complain transaction too large for the create table ... statement.
| _, err := tk.Exec(SQL) | ||
| c.Assert(err, NotNil) | ||
| c.Assert(err.Error(), Equals, "[ddl:1]MockRollingBackInCallBack-none") | ||
| c.Assert(err.Error(), Equals, "[ddl:1]MockRollingBackInCallBack-queueing") |
There was a problem hiding this comment.
This change is because we use the latest parser and it change the String() method
https://github.com/pingcap/parser/pull/1210/files#diff-a5ce247e55d5a20707517e34bef620f2eb369b4f9b8fa44fdfb2c18a702418e8R72
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 351d871 |
|
/run-integration-common-test |
|
/lgtm |
|
/merge |
|
/run-all-tests This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin). Silence the bot with the |
|
/run-all-tests This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin). Silence the bot with the |
|
/run-all-tests This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin). Silence the bot with the |
|
/run-check_title |
|
/run-check-title |
What problem does this PR solve?
Problem Summary:
What is changed and how it works?
Proposal: temporary table
What's Changed:
How it Works:
Support read and write operations for the global temporary table is quite simple.
Just discard the key-value belong to the temporary table before commit.
Check List
Tests
Release note