Skip to content

expression: Maintain separate scalar function pushdown lists for each engine instead of unified. (#23284)#23661

Merged
ti-chi-bot merged 4 commits intopingcap:release-5.0from
ti-srebot:release-5.0-26c0e7261d70
Jun 16, 2021
Merged

expression: Maintain separate scalar function pushdown lists for each engine instead of unified. (#23284)#23661
ti-chi-bot merged 4 commits intopingcap:release-5.0from
ti-srebot:release-5.0-26c0e7261d70

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 30, 2021 •
edited
Loading

cherry-pick #23284 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23661

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/23661:release-5.0-26c0e7261d70

What problem does this PR solve?

Problem Summary:

Currently, if I want to push a function down to TiFlash, I need to:

  1. add it in expression.canFuncBePushed (maybe already existed)
  2. add it in expression.scalarExprSupportedByFlash.
  3. consider whether to ban it in expression.scalarExprSupportedByTiKV
  4. consider whether to ban it in expression.scalarExprSupportedByTiDB

After this pr, there won't maintain a unified list, I can just add it in expression.scalarExprSupportedByFlash.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn: no need.
  • Need to cherry-pick to the release branch 4.0

Check List

Tests

  • Integration test

Side effects

Release note

  • No release note

@LittleFall @ti-srebot
cherry pick pingcap#23284 to release-5.0
12f6638 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner March 30, 2021 06:07
@ti-srebot ti-srebot requested review from XuHuaiyu and removed request for a team March 30, 2021 06:07
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Mar 30, 2021

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Mar 30, 2021
Merged
@ti-srebot ti-srebot added component/expression size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/5.0-cherry-pick labels Mar 30, 2021
@ti-srebot ti-srebot added this to the v5.0.0 ga milestone Mar 30, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Mar 30, 2021

@LittleFall you're already a collaborator in bot's repo.

@LittleFall LittleFall mentioned this pull request Apr 13, 2021
Merged
@JaySon-Huang JaySon-Huang mentioned this pull request Jun 4, 2021
Merged
@guo-shaoge guo-shaoge removed the request for review from XuHuaiyu June 10, 2021 02:33
@lzmhhh123 lzmhhh123 removed their request for review June 15, 2021 06:31
leiysky
leiysky approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@leiysky leiysky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 16, 2021
@fzhedu
Copy link
Contributor

fzhedu commented Jun 16, 2021

/LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 16, 2021

@fzhedu: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

1 similar comment
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 16, 2021

@fzhedu: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

fzhedu
fzhedu approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fzhedu
  • leiysky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 16, 2021
@fzhedu
Copy link
Contributor

fzhedu commented Jun 16, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 16, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 2835af2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2021
@LittleFall
Copy link
Contributor

LittleFall commented Jun 16, 2021 •
edited
Loading 

[2021-06-16T04:06:04.033Z] GitHub pull request #23661 of commit 2835af23ab5c2b9c0439839404b4afe3e2c8bcd5, no merge conflicts.

[2021-06-16T04:06:04.637Z] Setting status of 2835af23ab5c2b9c0439839404b4afe3e2c8bcd5 to PENDING with url https://ci.pingcap.net/job/tidb_ghpr_unit_test/5699/display/redirect and message: 'Jenkins job is running.'

[2021-06-16T04:06:04.637Z] Using context: idc-jenkins-ci-tidb/unit-test

[2021-06-16T04:06:07.511Z] Obtained jenkins/pipelines/ci/tidb/tidb_ghpr_unit_test.groovy from git git@github.com:PingCAP-QE/ci.git

[2021-06-16T04:06:07.511Z] Running in Durability level: MAX_SURVIVABILITY

[2021-06-16T04:06:07.561Z] Setting status of 2835af23ab5c2b9c0439839404b4afe3e2c8bcd5 to FAILURE with url https://ci.pingcap.net/job/tidb_ghpr_unit_test/5699/display/redirect and message: 'Jenkins job failed.

[2021-06-16T04:06:07.561Z]  '

[2021-06-16T04:06:07.561Z] Using context: idc-jenkins-ci-tidb/unit-test

[2021-06-16T04:06:08.115Z] org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:

[2021-06-16T04:06:08.115Z] WorkflowScript: 425: expecting ')', found '=' @ line 425, column 37.

[2021-06-16T04:06:08.115Z]                if (currentBuild.result = "ABORTED") {

[2021-06-16T04:06:08.115Z]                                        ^

[2021-06-16T04:06:08.115Z] 

[2021-06-16T04:06:08.115Z] 1 error

[2021-06-16T04:06:08.115Z] 

[2021-06-16T04:06:08.115Z] 	at org.codehaus.groovy.control.ErrorCollector.failIfErrors(ErrorCollector.java:310)

[2021-06-16T04:06:08.115Z] 	at org.codehaus.groovy.control.ErrorCollector.addFatalError(ErrorCollector.java:150)

[2021-06-16T04:06:08.115Z] 	at org.codehaus.groovy.control.ErrorCollector.addError(ErrorCollector.java:120)

[2021-06-16T04:06:08.115Z] 	at org.codehaus.groovy.control.ErrorCollector.addError(ErrorCollector.java:132)

[2021-06-16T04:06:08.115Z] 	at org.codehaus.groovy.control.SourceUnit.addError(SourceUnit.java:350)

[2021-06-16T04:06:08.115Z] 	at org.codehaus.groovy.antlr.AntlrParserPlugin.transformCSTIntoAST(AntlrParserPlugin.java:144)

[2021-06-16T04:06:08.115Z] 	at org.codehaus.groovy.antlr.AntlrParserPlugin.parseCST(AntlrParserPlugin.java:110)

[2021-06-16T04:06:08.115Z] 	at org.codehaus.groovy.control.SourceUnit.parse(SourceUnit.java:234)

[2021-06-16T04:06:08.115Z] 	at org.codehaus.groovy.control.CompilationUnit$1.call(CompilationUnit.java:168)

[2021-06-16T04:06:08.115Z] 	at org.codehaus.groovy.control.CompilationUnit.applyToSourceUnits(CompilationUnit.java:943)

[2021-06-16T04:06:08.115Z] 	at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:605)

[2021-06-16T04:06:08.115Z] 	at org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:581)

[2021-06-16T04:06:08.115Z] 	at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:558)

[2021-06-16T04:06:08.115Z] 	at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:298)

[2021-06-16T04:06:08.115Z] 	at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:268)

[2021-06-16T04:06:08.115Z] 	at groovy.lang.GroovyShell.parseClass(GroovyShell.java:688)

[2021-06-16T04:06:08.115Z] 	at groovy.lang.GroovyShell.parse(GroovyShell.java:700)

[2021-06-16T04:06:08.115Z] 	at org.jenkinsci.plugins.workflow.cps.CpsGroovyShell.doParse(CpsGroovyShell.java:142)

[2021-06-16T04:06:08.115Z] 	at org.jenkinsci.plugins.workflow.cps.CpsGroovyShell.reparse(CpsGroovyShell.java:127)

[2021-06-16T04:06:08.115Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.parseScript(CpsFlowExecution.java:571)

[2021-06-16T04:06:08.115Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.start(CpsFlowExecution.java:523)

[2021-06-16T04:06:08.115Z] 	at org.jenkinsci.plugins.workflow.job.WorkflowRun.run(WorkflowRun.java:337)

[2021-06-16T04:06:08.115Z] 	at hudson.model.ResourceController.execute(ResourceController.java:97)

[2021-06-16T04:06:08.115Z] 	at hudson.model.Executor.run(Executor.java:429)

[2021-06-16T04:06:08.115Z] Finished: FAILURE

@LittleFall
Copy link
Contributor

LittleFall commented Jun 16, 2021

/merge

@LittleFall
Copy link
Contributor

LittleFall commented Jun 16, 2021

/run-all-tests

2 similar comments
@LittleFall
Copy link
Contributor

LittleFall commented Jun 16, 2021

/run-all-tests

@zhouqiang-cl
Copy link
Contributor

zhouqiang-cl commented Jun 16, 2021

/run-all-tests

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 16, 2021
@zhouqiang-cl zhouqiang-cl removed the cherry-pick-approved Cherry pick PR approved by release team. label Jun 16, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 16, 2021
@ti-chi-bot ti-chi-bot merged commit 083d6a7 into pingcap:release-5.0 Jun 16, 2021
@LittleFall LittleFall deleted the release-5.0-26c0e7261d70 branch June 16, 2021 07:59
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.0 ga, v5.0.3 Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

@qw4990 qw4990 Awaiting requested review from qw4990

@windtalker windtalker Awaiting requested review from windtalker

2 more reviewers

@fzhedu fzhedu fzhedu approved these changes

@leiysky leiysky leiysky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LittleFall LittleFall

Labels

cherry-pick-approved Cherry pick PR approved by release team. component/expression size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick

Projects

None yet

Milestone

v5.0.3

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-srebot @fzhedu @ti-chi-bot @LittleFall @zhouqiang-cl @leiysky