Skip to content

variable: Add innodb_default_row_format as noop#23568

Merged
ti-chi-bot merged 6 commits intopingcap:masterfrom
morgo:add-innodb-default-row-format
Mar 30, 2021
Merged

variable: Add innodb_default_row_format as noop#23568
ti-chi-bot merged 6 commits intopingcap:masterfrom
morgo:add-innodb-default-row-format

Conversation

@morgo
Copy link
Contributor

@morgo morgo commented Mar 26, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: fixes #23541

Problem Summary:

JIRA needs to be able to set innodb_default_row_format to function correctly. This adds it as a noop, which is safe to be able to do.

The innodb_file_format is also changed to be Barracuda, because Dynamic is only possible with Barracuda. Barracuda is also the default in MySQL 5.7, and file_formats become obsolete in MySQL 8.0.

What is changed and how it works?

What's Changed:

A noop sysvar was added: innodb_default_row_format.

Related changes

  • None

Check List

Tests

  • Integration test

Side effects

  • Increased code complexity
  • More "fake" metadata (although safe in this case)

Release note

  • The system variable innodb_default_row_format was added for compatibility with Jira. Setting it has no effect.

@morgo morgo requested a review from a team as a code owner March 26, 2021 02:17
@morgo morgo requested review from qw4990 and removed request for a team March 26, 2021 02:17
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 26, 2021
@morgo morgo requested a review from djshow832 March 26, 2021 02:17
@morgo morgo added the sig/sql-infra SIG: SQL Infra label Mar 26, 2021
@jackysp
Copy link
Contributor

jackysp commented Mar 26, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 26, 2021
@morgo
Copy link
Contributor Author

morgo commented Mar 26, 2021

/run-check_dev_2

zz-jason
zz-jason reviewed Mar 27, 2021
View reviewed changes
@djshow832
Copy link
Contributor

djshow832 commented Mar 29, 2021

/lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 29, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • jackysp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 29, 2021
zz-jason
zz-jason approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 30, 2021

@zz-jason: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zz-jason
Copy link
Member

zz-jason commented Mar 30, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 30, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: fb00bfc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 30, 2021
@morgo
Copy link
Contributor Author

morgo commented Mar 30, 2021

/run-unit-test

@morgo
Copy link
Contributor Author

morgo commented Mar 30, 2021

/run-unit-test

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 30, 2021

@morgo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 017790b into pingcap:master Mar 30, 2021
@morgo morgo mentioned this pull request May 11, 2021
Merged
@morgo morgo deleted the add-innodb-default-row-format branch May 11, 2021 14:06
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2021
Merged
@ti-srebot ti-srebot mentioned this pull request Jul 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zz-jason zz-jason zz-jason approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@djshow832 djshow832 Awaiting requested review from djshow832

Assignees

No one assigned

Labels

component/expression sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compatible with mysql 5.7 noop variables: innodb_default_row_format

5 participants

@morgo @jackysp @djshow832 @ti-chi-bot @zz-jason