Skip to content

store/tikv: remove kv.Version from package store/tikv#23282

Merged
ti-chi-bot merged 6 commits intopingcap:masterfrom
AndreMouche:store/tikv/version
Mar 13, 2021
Merged

store/tikv: remove kv.Version from package store/tikv#23282
ti-chi-bot merged 6 commits intopingcap:masterfrom
AndreMouche:store/tikv/version

Conversation

@AndreMouche
Copy link
Contributor

@AndreMouche AndreMouche commented Mar 12, 2021 •
edited
Loading

Signed-off-by: AndreMouche

What problem does this PR solve?

This PR removes the usage of kv.Version from tikv package
Part of #22513

Check List

Tests

  • Unit test

Release note

  • No release note

@AndreMouche
store/tikv:remove kv.Version from package store/tikv
e78e89a 
Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche AndreMouche added the sig/transaction SIG:Transaction label Mar 12, 2021
@AndreMouche AndreMouche requested a review from a team as a code owner March 12, 2021 07:58
@AndreMouche AndreMouche requested review from lzmhhh123 and removed request for a team March 12, 2021 07:58
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 12, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Mar 12, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2021
disksing
disksing reviewed Mar 12, 2021
View reviewed changes
disksing
disksing reviewed Mar 12, 2021
View reviewed changes
disksing
disksing reviewed Mar 12, 2021
View reviewed changes
disksing
disksing reviewed Mar 12, 2021
View reviewed changes
@AndreMouche
store/tikv:address comments
ef14000 
Signed-off-by: shirly <AndreMouche@126.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • andylokandy
  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2021
@AndreMouche
store/tikv:fix tests
561b671 
Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche
Copy link
Contributor Author

AndreMouche commented Mar 13, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 13, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 561b671

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 13, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 13, 2021

@AndreMouche: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit b534ec7 into pingcap:master Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andylokandy andylokandy andylokandy approved these changes

@disksing disksing disksing approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees

No one assigned

Labels

sig/execution SIG execution sig/transaction SIG:Transaction size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AndreMouche @ti-chi-bot @andylokandy @disksing