Skip to content

session: enable async commit in new clusters#23274

Merged
youjiali1995 merged 10 commits intopingcap:masterfrom
sticnarf:async-commit-config-adj
Mar 12, 2021
Merged

session: enable async commit in new clusters#23274
youjiali1995 merged 10 commits intopingcap:masterfrom
sticnarf:async-commit-config-adj

Conversation

@sticnarf
Copy link
Contributor

@sticnarf sticnarf commented Mar 12, 2021

What is changed and how it works?

This is some configuration adjustments for async commit.

We hope to enable async commit and 1PC by default for newly created TiDB 5.0 clusters.

And SafeWindow and AllowedClockDrift are made configurable, in case some users have very special requirements (like running a lot of ADD INDEX DDLs).

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

  • Enable async commit in new clusters.

@sticnarf
session: enable async commit in new clusters
fee25e0 
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf sticnarf added the sig/transaction SIG:Transaction label Mar 12, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 12, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Mar 12, 2021
@youjiali1995 youjiali1995 requested a review from ekexium March 12, 2021 06:11
@youjiali1995 youjiali1995 added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Mar 12, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2021
@ekexium
Copy link
Member

ekexium commented Mar 12, 2021

/lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • MyonKeminta
  • ekexium

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2021
@sticnarf
Copy link
Contributor Author

sticnarf commented Mar 12, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: fee25e0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021
@sticnarf
Copy link
Contributor Author

sticnarf commented Mar 12, 2021

/run-all-tests

@sticnarf
Copy link
Contributor Author

sticnarf commented Mar 12, 2021

/run-unit-test

@youjiali1995
Copy link
Contributor

youjiali1995 commented Mar 12, 2021

/merge

@sticnarf
Copy link
Contributor Author

sticnarf commented Mar 12, 2021

/merge

@sticnarf
Copy link
Contributor Author

sticnarf commented Mar 12, 2021

/run-unit-test

@sticnarf
Copy link
Contributor Author

sticnarf commented Mar 12, 2021

/merge

@sticnarf
Copy link
Contributor Author

sticnarf commented Mar 12, 2021

/run-unit-test

@youjiali1995
Copy link
Contributor

youjiali1995 commented Mar 12, 2021

/merge

@youjiali1995
Copy link
Contributor

youjiali1995 commented Mar 12, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

@sticnarf: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sticnarf
Copy link
Contributor Author

sticnarf commented Mar 12, 2021

/run-unit-test

@sticnarf
Copy link
Contributor Author

sticnarf commented Mar 12, 2021

RACE: https://internal.pingcap.net/idc-jenkins/blue/rest/organizations/jenkins/pipelines/tidb_ghpr_unit_test/runs/67540/nodes/82/steps/339/log/?start=0
Seems not related to this PR.

@sticnarf
Copy link
Contributor Author

sticnarf commented Mar 12, 2021

/run-unit-test

@youjiali1995 youjiali1995 merged commit 088fe75 into pingcap:master Mar 12, 2021
This was referenced Mar 16, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MyonKeminta MyonKeminta MyonKeminta approved these changes

@youjiali1995 youjiali1995 Awaiting requested review from youjiali1995

@ekexium ekexium Awaiting requested review from ekexium

Assignees

No one assigned

Labels

priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sticnarf @ekexium @ti-chi-bot @youjiali1995 @MyonKeminta