Skip to content

statistics: add multi-column index test cases for global-statas#23265

Merged
qw4990 merged 3 commits intopingcap:masterfrom
qw4990:global-stats-test3
Mar 12, 2021
Merged

statistics: add multi-column index test cases for global-statas#23265
qw4990 merged 3 commits intopingcap:masterfrom
qw4990:global-stats-test3

Conversation

@qw4990
Copy link
Contributor

@qw4990 qw4990 commented Mar 11, 2021

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: statistics: add multi-column index test cases for global-statas

What is changed and how it works?

statistics: add multi-column index test cases for global-statas

Check List

Tests

  • Unit test

Release note

  • statistics: add multi-column index test cases for global-statas

@qw4990 qw4990 requested review from Reminiscent and rebelice March 11, 2021 09:38
@qw4990 qw4990 requested a review from a team as a code owner March 11, 2021 09:38
@qw4990 qw4990 requested review from eurekaka and removed request for a team March 11, 2021 09:38
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 11, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2021
Reminiscent
Reminiscent approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2021
@Reminiscent
Copy link
Contributor

Reminiscent commented Mar 12, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

@Reminiscent: /merge is only allowed for the committers in list.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990 qw4990 merged commit 2258ab7 into pingcap:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rebelice rebelice rebelice approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

+1 more reviewer

@Reminiscent Reminiscent Reminiscent approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/statistics sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qw4990 @ti-chi-bot @Reminiscent @rebelice