Skip to content

planner, table: set PrimaryPrefixColumnIds correctly#23250

Merged
ti-chi-bot merged 12 commits intopingcap:masterfrom
wjhuang2016:fix_clustered_index_prefix
Mar 12, 2021
Merged

planner, table: set PrimaryPrefixColumnIds correctly#23250
ti-chi-bot merged 12 commits intopingcap:masterfrom
wjhuang2016:fix_clustered_index_prefix

Conversation

@wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Mar 11, 2021

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Problem Summary:

Some usages of BuildTableScanFromInfos() doesn't set PrimaryPrefixColumnIds.

What is changed and how it works?

set PrimaryPrefixColumnIds in BuildTableScanFromInfos().

Related changes

Check List

Tests

  • No code

Side effects

Release note

  • No release note

@wjhuang2016
done
06d2b13 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016 wjhuang2016 requested a review from a team as a code owner March 11, 2021 05:27
@wjhuang2016 wjhuang2016 requested review from hanfei1991 and removed request for a team March 11, 2021 05:27
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 11, 2021
@wjhuang2016
Copy link
Member Author

wjhuang2016 commented Mar 11, 2021

/cc @tangenta @lysu

@ti-chi-bot ti-chi-bot requested review from lysu and tangenta March 11, 2021 05:27
@lysu
Copy link
Contributor

lysu commented Mar 11, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2021
tangenta
tangenta reviewed Mar 11, 2021
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can remove these lines:

tidb/planner/core/plan_to_pb.go

Lines 200 to 202 in 6bd6df7

if p.Table.IsCommonHandle {
tsExec.PrimaryPrefixColumnIds = tables.PrimaryPrefixColumnIDs(p.Table)
}

Should we add some tests to make sure ADD INDEX and RECOVER INDEX works?

@tangenta
Copy link
Contributor

tangenta commented Mar 12, 2021

/lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2021
@wjhuang2016
test
7206ce0 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
1
e2c46dc 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016 wjhuang2016 force-pushed the fix_clustered_index_prefix branch from d4a85ec to e2c46dc Compare March 12, 2021 05:43
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2021
@wjhuang2016
2
e3eef94 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Mar 12, 2021
@wjhuang2016
fix
f03a96e 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
Merge branch 'master' into fix_clustered_index_prefix
10403d2
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2021
@wjhuang2016
Copy link
Member Author

wjhuang2016 commented Mar 12, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 10403d2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021
@tangenta
Copy link
Contributor

tangenta commented Mar 12, 2021

Related to #22811.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

@wjhuang2016: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit fcf60e0 into pingcap:master Mar 12, 2021
@wjhuang2016 wjhuang2016 deleted the fix_clustered_index_prefix branch November 17, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tangenta tangenta tangenta left review comments

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

@lysu lysu Awaiting requested review from lysu

Assignees

No one assigned

Labels

sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wjhuang2016 @lysu @tangenta @ti-chi-bot