Skip to content

ddl: make TestNotifyDDLJob stable#23232

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
zimulala:stable-nodify
Mar 11, 2021
Merged

ddl: make TestNotifyDDLJob stable#23232
ti-chi-bot merged 4 commits intopingcap:masterfrom
zimulala:stable-nodify

Conversation

@zimulala
Copy link
Contributor

@zimulala zimulala commented Mar 10, 2021

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

[2021-03-09T09:00:56.914Z] ----------------------------------------------------------------------
[2021-03-09T09:00:56.914Z] FAIL: ddl_worker_test.go:80: testDDLSuite.TestNotifyDDLJob
[2021-03-09T09:00:56.914Z]
[2021-03-09T09:00:56.914Z] ddl_worker_test.go:128:
[2021-03-09T09:00:56.914Z]     c.Fatal("do not get the add index job notification")
[2021-03-09T09:00:56.914Z] ... Error: do not get the add index job notification
[2021-03-09T09:00:56.914Z]

What is changed and how it works?

Proposal: xxx

How it Works:

Ensure that the notification is not handled by the worker's "start".

Check List

Tests

  • No code

Release note

  • No release note.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 10, 2021
@zimulala
Copy link
Contributor Author

zimulala commented Mar 10, 2021

/cc @xhebox @bb7133 @crazycs520

AilinKid
AilinKid reviewed Mar 10, 2021
View reviewed changes
@AilinKid
Copy link
Contributor

AilinKid commented Mar 10, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2021
xhebox
xhebox approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 10, 2021

@xhebox: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 10, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 10, 2021
@ngaut
Copy link
Member

ngaut commented Mar 11, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 11, 2021

@ngaut: /merge is only allowed for the committers in list.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xhebox
Copy link
Contributor

xhebox commented Mar 11, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 11, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b8c5f03

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2021
@ti-chi-bot ti-chi-bot merged commit f21c7dd into pingcap:master Mar 11, 2021
@zimulala zimulala deleted the stable-nodify branch March 12, 2021 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AilinKid AilinKid AilinKid left review comments

@xhebox xhebox xhebox approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@crazycs520 crazycs520 Awaiting requested review from crazycs520

Assignees

No one assigned

Labels

component/test sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zimulala @AilinKid @ti-chi-bot @ngaut @xhebox