Skip to content

store/tikv: remove tidb/metrics from store/tikv#23221

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
aierui:tikv_metrics
Mar 12, 2021
Merged

store/tikv: remove tidb/metrics from store/tikv#23221
ti-chi-bot merged 3 commits intopingcap:masterfrom
aierui:tikv_metrics

Conversation

@aierui
Copy link
Contributor

@aierui aierui commented Mar 9, 2021

What problem does this PR solve?

Remove store/tikv's dependency on tidb/metrics
Part of #22513

What is changed and how it works?

What's Changed:

store/tikv: remove tidb/metrics from store/tikv/region_request.go

Check List

Tests

  • Unit test

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 9, 2021
@aierui
Copy link
Contributor Author

aierui commented Mar 9, 2021

/run-all-tests

@aierui
Copy link
Contributor Author

aierui commented Mar 10, 2021

/run-all-tests

1 similar comment
@disksing
Copy link
Contributor

disksing commented Mar 10, 2021

/run-all-tests

@disksing disksing requested a review from AndreMouche March 10, 2021 05:02
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2021
AndreMouche
AndreMouche approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

@AndreMouche: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AndreMouche
  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2021
@AndreMouche
Copy link
Contributor

AndreMouche commented Mar 12, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 5c0bb6a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

@aierui: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit f0ccc57 into pingcap:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreMouche AndreMouche AndreMouche approved these changes

@disksing disksing disksing approved these changes

Assignees

No one assigned

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aierui @disksing @ti-chi-bot @AndreMouche