Skip to content

ddl: migrate part of ddl package code from Execute/ExecRestricted to safe API (2) (#22729)#23084

Merged
ti-chi-bot merged 3 commits intopingcap:release-2.1from
AilinKid:local-inject2-2.1
Mar 4, 2021
Merged

ddl: migrate part of ddl package code from Execute/ExecRestricted to safe API (2) (#22729)#23084
ti-chi-bot merged 3 commits intopingcap:release-2.1from
AilinKid:local-inject2-2.1

Conversation

@AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Mar 3, 2021

What problem does this PR solve?

cherry-pick #22729 to release-2.1

Release note

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 3, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Mar 3, 2021
xhebox
xhebox requested changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the build

@AilinKid
.
0412dfb 
Signed-off-by: ailinkid <314806019@qq.com>
@xhebox
Copy link
Contributor

xhebox commented Mar 4, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 4, 2021
@tangenta
Copy link
Contributor

tangenta commented Mar 4, 2021

/lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 4, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 4, 2021
@xhebox
Copy link
Contributor

xhebox commented Mar 4, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 4, 2021

@xhebox: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 4, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 0412dfb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 4, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 4, 2021

@AilinKid: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 3d7da99 into pingcap:release-2.1 Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox requested changes

Assignees

No one assigned

Labels

sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AilinKid @xhebox @tangenta @ti-chi-bot