ddl: migrate part of ddl package code from Execute/ExecRestricted to safe API (2) (#22729)#22936
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
|
@AilinKid you're already a collaborator in bot's repo. |
ddl/partition.go
Outdated
| sql = buildCheckSQLForRangeColumnsPartition(pi, index, schemaName, tableName) | ||
| sql, paramList = buildCheckSQLForRangeColumnsPartition(pi, index, schemaName, tableName) | ||
| } | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Please resolve conflicts
Signed-off-by: ailinkid <314806019@qq.com>
|
/lgtm |
|
/LGTM |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by writing |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 82dd1b2 |
cherry-pick #22729 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/22936After apply modifications, you can push your change to this PR via:
Signed-off-by: AilinKid 314806019@qq.com
What problem does this PR solve?
Issue Number: part close #pingcap/tidb-test#1152
What is changed and how it works?
What's Changed:
Migrate part of code in ddl package from using Execute/ExecRestricted to safe API
Attention:
1: Since partitionDef.Expr string may contain the identifier, we won't pass it as a parameter but write it to SQL string directly.
2: Since the condition string in partitionDef.less-than field contains the quotation ", so trimming need be done before it passed as a string parameter.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note