Skip to content

gcworker: remove handler interface#22779

Merged
ti-srebot merged 5 commits intopingcap:masterfrom
disksing:gc-handler
Feb 18, 2021
Merged

gcworker: remove handler interface#22779
ti-srebot merged 5 commits intopingcap:masterfrom
disksing:gc-handler

Conversation

@disksing
Copy link
Contributor

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Remove the GCHandler interface and use the concrete GCWorker directly.
Part of #22513

What is changed and how it works?

What's Changed:

  • remove GCHandler interface
  • remove NewGCHandlerFunc

Check List

Tests

  • Unit test

Release note

  • No release note

Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the sig/transaction SIG:Transaction label Feb 17, 2021
Signed-off-by: disksing <i@disksing.com>
@disksing
Copy link
Contributor Author

/run-all-tests

Signed-off-by: disksing <i@disksing.com>
@disksing disksing marked this pull request as ready for review February 17, 2021 06:54
@disksing
Copy link
Contributor Author

/run-all-tests

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Feb 17, 2021
@disksing disksing marked this pull request as draft February 17, 2021 07:08
@disksing
Copy link
Contributor Author

/run-all-tests

1 similar comment
@disksing
Copy link
Contributor Author

/run-all-tests

@disksing disksing marked this pull request as ready for review February 17, 2021 07:35
Copy link
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 18, 2021
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 18, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 18, 2021
@AndreMouche
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 18, 2021
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 21230

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@disksing merge failed.

@AndreMouche
Copy link
Contributor

/merge

@AndreMouche
Copy link
Contributor

/run-all-tests

@disksing
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 4031706 into pingcap:master Feb 18, 2021
@disksing disksing deleted the gc-handler branch February 18, 2021 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants