util/timeutil: fix timeutil/time_test.go on Windows#22758
Merged
ti-srebot merged 1 commit intopingcap:masterfrom Feb 8, 2021
skyline75489:patch-1
Merged
util/timeutil: fix timeutil/time_test.go on Windows#22758ti-srebot merged 1 commit intopingcap:masterfrom skyline75489:patch-1
ti-srebot merged 1 commit intopingcap:masterfrom
skyline75489:patch-1
Conversation
|
|
Contributor
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
Contributor
|
/run-check_release_note |
Contributor
|
LGTM |
ti-srebot
approved these changes
Feb 8, 2021
Contributor
|
/merge |
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary: The test case fails on Windows because of pure Unix paths.
What is changed and how it works?
What's Changed: Switching to
filepath.Join(os.TempDir(), "path").How it Works:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note