Skip to content

*: uprgade gopsutil to v3.20.12#22747

Merged
ti-srebot merged 3 commits intopingcap:masterfrom
wshwsh12:build_tidb
Feb 5, 2021
Merged

*: uprgade gopsutil to v3.20.12#22747
ti-srebot merged 3 commits intopingcap:masterfrom
wshwsh12:build_tidb

Conversation

@wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Feb 5, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: tidb master branch 75f7485 build failed in MacOS. same with pingcap/ticdc#1385

../../../.gvm/pkgsets/go1.15/global/pkg/mod/github.com/shirou/gopsutil@v2.20.6+incompatible/disk/disk_darwin.go:67:51: cannot use stat.Mntfromname[:] (type []byte) as type []int8 in argument to common.IntToString
../../../.gvm/pkgsets/go1.15/global/pkg/mod/github.com/shirou/gopsutil@v2.20.6+incompatible/disk/disk_darwin.go:68:49: cannot use stat.Mntonname[:] (type []byte) as type []int8 in argument to common.IntToString
../../../.gvm/pkgsets/go1.15/global/pkg/mod/github.com/shirou/gopsutil@v2.20.6+incompatible/disk/disk_darwin.go:69:50: cannot use stat.Fstypename[:] (type []byte) as type []int8 in argument to common.IntToString
../../../.gvm/pkgsets/go1.15/global/pkg/mod/github.com/shirou/gopsutil@v2.20.6+incompatible/disk/disk_darwin.go:85:43: cannot use stat.Fstypename[:] (type []byte) as type []int8 in argument to common.IntToString

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@wshwsh12 wshwsh12 requested a review from XuHuaiyu February 5, 2021 07:11
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Feb 5, 2021

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 5, 2021
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 5, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 5, 2021
@AndreMouche
Copy link
Contributor

AndreMouche commented Feb 5, 2021

/merge

@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Feb 5, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 5, 2021
@ti-srebot
Copy link
Contributor

ti-srebot commented Feb 5, 2021

/run-all-tests

@ti-srebot ti-srebot merged commit 46accce into pingcap:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreMouche AndreMouche AndreMouche approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

No one assigned

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wshwsh12 @XuHuaiyu @AndreMouche @ti-srebot