Skip to content

session: ignore linearizability setting for auto-commit transactions#22746

Merged
ti-srebot merged 2 commits intopingcap:masterfrom
sticnarf:auto-commit-linearizability
Feb 18, 2021
Merged

session: ignore linearizability setting for auto-commit transactions#22746
ti-srebot merged 2 commits intopingcap:masterfrom
sticnarf:auto-commit-linearizability

Conversation

@sticnarf
Copy link
Contributor

@sticnarf sticnarf commented Feb 5, 2021

What is changed and how it works?

Linearizability is naturally guaranteed for auto-commit transactions even if async commit or 1PC is enabled. We can omit the extra TSO request.

Check List

Tests

  • Unit test

Release note

  • Make linearizability settings not affect auto-commit transactions.

Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf sticnarf added the sig/transaction SIG:Transaction label Feb 5, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Feb 5, 2021
Copy link
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 18, 2021
…rizability

Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Copy link
Contributor

@youjiali1995 youjiali1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 18, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 18, 2021
@youjiali1995
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 18, 2021
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@sticnarf merge failed.

@sticnarf
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants