Skip to content

server: fix tcp-keep-alive config#22745

Merged
ti-srebot merged 1 commit intopingcap:masterfrom
jackysp:keepalive
Feb 5, 2021
Merged

server: fix tcp-keep-alive config#22745
ti-srebot merged 1 commit intopingcap:masterfrom
jackysp:keepalive

Conversation

@jackysp
Copy link
Contributor

@jackysp jackysp commented Feb 5, 2021

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:
tcp-keep-alive could not disable TCP keepalive if it is set to false.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:
Make newConn could disable TCP keepalive, because it is enabled by default.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  1. set tcp-keep-alive to false
  2. tcp dump the packet between an idle client and TiDB server.

Release note

  • No release note

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp jackysp added component/server type/bugfix This PR fixes a bug. labels Feb 5, 2021
@jackysp jackysp requested review from bb7133, lonng and lysu February 5, 2021 06:55
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 5, 2021
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 5, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 5, 2021
@bb7133
Copy link
Member

bb7133 commented Feb 5, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 5, 2021
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 7f8935a into pingcap:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/server status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants