server: return OK when there is no stmt#22738
Merged
ti-srebot merged 4 commits intopingcap:release-4.0from Feb 5, 2021
Merged
Conversation
jackysp
reviewed
Feb 5, 2021
Contributor
jackysp
left a comment
There was a problem hiding this comment.
Is it possible to add a unit test case?
Contributor
Author
Done |
Member
|
LGTM |
Contributor
Author
|
Note: I've changed the test to add a timeout component. There is no test for master for this case, so I will prepare another PR shortly. |
ti-srebot
approved these changes
Feb 5, 2021
|
/merge |
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Fixes #22646
Problem Summary:
There was a regression introduced in the 4.0 branch by a cherry-pick. The issue does not exist in the master branch, or any public released binaries yet. It was caught before 4.0.11 was released. It does not exist in 4.0.10.
I am unsure if connectors rely on this functionality. There is a
COM_PINGprotocol feature, but it's possible that an incorrectly implemented driver uses an empty query instead. In which case it could be quite a serious issue.What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note