*: refactor ExecuteInternal to return single resultset (#22546)#22712
Closed
ti-srebot wants to merge 1 commit intopingcap:release-3.0from
Closed
*: refactor ExecuteInternal to return single resultset (#22546)#22712ti-srebot wants to merge 1 commit intopingcap:release-3.0from
ti-srebot wants to merge 1 commit intopingcap:release-3.0from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
@morgo please accept the invitation then you can push to the cherry-pick pull requests. |
Contributor
|
Closing. This will need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #22546 to release-3.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/22712After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Problem Summary:
Both
ExecuteandExecuteInternalno longer permit multi-statement, but the return type was maintained the same for backward compatibility.This changes
ExecuteInternalto return a single result-set.Update: I've removed
Executefrom this PR, we can handle it in followup PRs.What is changed and how it works?
What's Changed:
This changes the return type of
ExecuteInternalto be a non-array value.All uses of(for future PRs - it does not need to be handled all at once).Executeare changed to useExecuteInternalRelated changes
Check List
Tests
Side effects
Release note