Skip to content

statistics,executor: fix some unit tests that run twice#22705

Merged
ti-srebot merged 3 commits intopingcap:masterfrom
tiancaiamao:test-twice
Feb 5, 2021
Merged

statistics,executor: fix some unit tests that run twice#22705
ti-srebot merged 3 commits intopingcap:masterfrom
tiancaiamao:test-twice

Conversation

@tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Feb 3, 2021

What problem does this PR solve?

Issue Number: close #22664

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

The base test suite should not implement TestXXX, otherwise, the overloaded test suite will run the TestXXX twice.

Check List

Tests

  • Unit test

Release note

  • No release note

@tiancaiamao tiancaiamao requested review from a team as code owners February 3, 2021 12:11
@tiancaiamao tiancaiamao requested review from lzmhhh123 and qw4990 and removed request for a team February 3, 2021 12:11
@tiancaiamao tiancaiamao added type/enhancement The issue or PR belongs to an enhancement. component/test labels Feb 3, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Feb 3, 2021
@tiancaiamao
Copy link
Contributor Author

/run-check_dev_2

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 4, 2021
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 5, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 5, 2021
@qw4990
Copy link
Contributor

qw4990 commented Feb 5, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 5, 2021
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 22667

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 9a2997f into pingcap:master Feb 5, 2021
@tiancaiamao tiancaiamao deleted the test-twice branch February 5, 2021 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/test sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some test case run twice

4 participants