Skip to content

expression: refine performance of EXTRACT function#22701

Merged
ti-srebot merged 19 commits intopingcap:masterfrom
leiysky:enhancement/extract-datetime-from-string
Feb 19, 2021
Merged

expression: refine performance of EXTRACT function#22701
ti-srebot merged 19 commits intopingcap:masterfrom
leiysky:enhancement/extract-datetime-from-string

Conversation

@leiysky
Copy link
Contributor

@leiysky leiysky commented Feb 3, 2021

What problem does this PR solve?

Issue Number: close #22700

Problem Summary:

What is changed and how it works?

What's Changed:

  • Add builtinExtractDatetimeFromStringSig

How it Works:

Related changes

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Refine performance of EXTRACT function

@leiysky
Copy link
Contributor Author

leiysky commented Feb 4, 2021

Waiting for pingcap/tipb#213

@leiysky leiysky marked this pull request as ready for review February 4, 2021 05:46
@leiysky leiysky requested a review from a team as a code owner February 4, 2021 05:46
@leiysky leiysky requested review from qw4990 and removed request for a team February 4, 2021 05:46
@leiysky
Copy link
Contributor Author

leiysky commented Feb 4, 2021

/run-all-tests

2 similar comments
@leiysky
Copy link
Contributor Author

leiysky commented Feb 4, 2021

/run-all-tests

@leiysky
Copy link
Contributor Author

leiysky commented Feb 4, 2021

/run-all-tests

@leiysky
Copy link
Contributor Author

leiysky commented Feb 4, 2021

@lzmhhh123 PTAL

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 19, 2021
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 19, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 19, 2021
@leiysky
Copy link
Contributor Author

leiysky commented Feb 19, 2021

/merge

@ti-srebot
Copy link
Contributor

@leiysky Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIG: execution(slack).

@leiysky
Copy link
Contributor Author

leiysky commented Feb 19, 2021

/run-all-tests

@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 19, 2021
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 22790
  • 22785

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit c9e85ec into pingcap:master Feb 19, 2021
@leiysky leiysky deleted the enhancement/extract-datetime-from-string branch February 19, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implementation of EXTRACT function is very inefficient

4 participants