expression: speed up Column.VecEvalReal by using MergeNulls#22191
Merged
zz-jason merged 8 commits intopingcap:masterfrom Feb 17, 2021
Merged
expression: speed up Column.VecEvalReal by using MergeNulls#22191zz-jason merged 8 commits intopingcap:masterfrom
zz-jason merged 8 commits intopingcap:masterfrom
Conversation
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-all-tests |
Contributor
Author
Some question about tests in TiDBHad a really difficult time to debug a randgen integration test, anyway to view the integration test or to provide more info on failed tests? for instance, in this integration test, I could barely get anything useful except from panic info I hardcoded inside. |
Member
|
PTAL @zhouqiang-cl |
Contributor
Got, we will improve it. /cc @Tjianke |
Contributor
Author
|
@lzmhhh123 @qw4990 PTAL, thanks~ |
Contributor
Author
|
@qw4990 PTAL, thanks~ |
Member
|
LGTM |
ti-srebot
approved these changes
Feb 8, 2021
Contributor
|
/merge |
Contributor
|
/run-all-tests |
Contributor
|
@Tjianke merge failed. |
Contributor
Author
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What problem does this PR solve?
Issue Number: close #22190
Problem Summary:
improve efficiency of
Column.VecEvalReal()withColumn.MergeNulls()What is changed and how it works?
What's Changed:
expression/column.go: use
Column.MergeNulls()before copying src element to resultRelated changes
Tests
Benchmark
use
BenchmarkVectorizedBuiltinArithmeticFuncto benchmarkbenchmark func:
Release note
Reference
Another PR that utilized MergeNulls() to speed up functions #12674