expression: fix comparing json with string (#21903)#21958
Merged
qw4990 merged 5 commits intopingcap:release-4.0from Jan 26, 2021
Merged
expression: fix comparing json with string (#21903)#21958qw4990 merged 5 commits intopingcap:release-4.0from
qw4990 merged 5 commits intopingcap:release-4.0from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
@ichn-hu you're already a collaborator in bot's repo. |
Contributor
|
@XuHuaiyu @lzmhhh123 PTAL |
zz-jason
previously approved these changes
Jan 25, 2021
Member
|
/merge |
Contributor
Author
|
Your auto merge job has been accepted, waiting for:
|
Contributor
|
Please resolve conflicts. @ichn-hu |
Contributor
|
/run-all-tests |
qw4990
approved these changes
Jan 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #21903 to release-4.0
What problem does this PR solve?
Issue Number: close #11883 , also close #13710
Problem Summary:
What is changed and how it works?
What's Changed: remove Parse json tag
How it Works:
MySQL won't implicitly cast string to JSON during comparison.
Related changes
Check List
Tests
Side effects
Release note