Skip to content

executor: support exact staleness begin statement#21897

Merged
ti-srebot merged 29 commits intopingcap:masterfrom
Yisaer:support_timestamp_readonly_txn
Dec 31, 2020
Merged

executor: support exact staleness begin statement#21897
ti-srebot merged 29 commits intopingcap:masterfrom
Yisaer:support_timestamp_readonly_txn

Conversation

@Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Dec 21, 2020 •
edited
Loading

What problem does this PR solve?

Issue Number: close #21821

What is changed and how it works?

Support Begin a read-only staleness transaction for the following types:

-- start a read-only transaction which reads the exact snapshot 5 seconds ago:
START TRANSACTION READ ONLY WITH TIMESTAMP BOUND EXACT STALENESS '00:00:05';

-- start a read-only transaction which reads the exact snapshot at "2020-09-06 00:00:00":
START TRANSACTION READ ONLY WITH TIMESTAMP BOUND READ TIMESTAMP '2020-09-06 00:00:00';

Release note

  • No release note

@Yisaer Yisaer requested a review from a team as a code owner December 21, 2020 08:05
@Yisaer Yisaer requested review from XuHuaiyu and removed request for a team December 21, 2020 08:05
@github-actions github-actions bot added the sig/execution SIG execution label Dec 21, 2020
@Yisaer Yisaer marked this pull request as draft December 21, 2020 09:38
@Yisaer Yisaer marked this pull request as ready for review December 22, 2020 11:43
@Yisaer
Copy link
Contributor Author

Yisaer commented Dec 22, 2020

/cc @djshow832

@ti-srebot ti-srebot requested a review from djshow832 December 22, 2020 11:46
djshow832
djshow832 reviewed Dec 23, 2020
View reviewed changes
djshow832
djshow832 reviewed Dec 23, 2020
View reviewed changes
djshow832
djshow832 reviewed Dec 27, 2020
View reviewed changes
@ti-srebot
Copy link
Contributor

ti-srebot commented Dec 29, 2020

@djshow832, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: execution(slack).

@djshow832 djshow832 removed the sig/execution SIG execution label Dec 30, 2020
@djshow832
Copy link
Contributor

djshow832 commented Dec 30, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 30, 2020
@github-actions github-actions bot added the sig/execution SIG execution label Dec 30, 2020
@djshow832 djshow832 requested a review from nolouch December 31, 2020 06:32
@djshow832 djshow832 removed the sig/execution SIG execution label Dec 31, 2020
@github-actions github-actions bot added the sig/execution SIG execution label Dec 31, 2020
nolouch
nolouch approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot
Copy link
Contributor

ti-srebot commented Dec 31, 2020

@nolouch, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: execution(slack).

@nolouch nolouch removed the sig/execution SIG execution label Dec 31, 2020
@github-actions github-actions bot added the sig/execution SIG execution label Dec 31, 2020
@pingcap pingcap deleted a comment from ti-srebot Dec 31, 2020
@nolouch nolouch removed the sig/execution SIG execution label Dec 31, 2020
@nolouch
Copy link
Member

nolouch commented Dec 31, 2020

lgtm

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 31, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 31, 2020
@nolouch nolouch added the sig/execution SIG execution label Dec 31, 2020
@Yisaer
Copy link
Contributor Author

Yisaer commented Dec 31, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 31, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Dec 31, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit eae64e4 into pingcap:master Dec 31, 2020
@Yisaer
Copy link
Contributor Author

Yisaer commented Jan 13, 2021

/label sig/infra

@ti-srebot ti-srebot added the sig/sql-infra SIG: SQL Infra label Jan 13, 2021
@nolouch nolouch mentioned this pull request Apr 26, 2021
Closed
2 tasks
@nolouch nolouch mentioned this pull request May 11, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djshow832 djshow832 djshow832 left review comments

@nolouch nolouch nolouch approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

No one assigned

Labels

sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Begin a staleness read-only transaction

4 participants

@Yisaer @ti-srebot @djshow832 @nolouch