types, expression, codec: agg JSON values#21656
Merged
ti-srebot merged 2 commits intopingcap:masterfrom Dec 11, 2020
Merged
Conversation
|
There is no reward for this challenge pull request, so you can request a reward from @qw4990. |
Contributor
Author
|
/run-all-tests |
Closed
ti-srebot
approved these changes
Dec 11, 2020
Contributor
|
/merge |
Contributor
|
/run-all-tests |
Member
|
I think TiKV need to be fixed as well |
Contributor
Author
I've re-opened the original issue to investigate. But in my testing, I've not been able to reproduce yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Fix #10467
What is changed and how it works?
MySQL can group the JSON values
3and3.0together in a group by statement, versus TiDB which currently handles these separately.This picks up the PR #15973 , but modifies it to only convert values to float when safe to do so. I think ideally the
DECIMALtype should be used to compare values with fixed-point math, which depends on #9988This means that there are some cases (which are left as comments in the integration test) which are handled correctly in MySQL, but not yet in TiDB.
Related changes
Check List
Tests
Side effects
(It's a little bit slower to do this of course.)
Release note