Skip to content

executor: fix split table with large integers#21277

Merged
ti-chi-bot merged 9 commits intopingcap:masterfrom
tangenta:fix-split-corner-case
Mar 15, 2021
Merged

executor: fix split table with large integers#21277
ti-chi-bot merged 9 commits intopingcap:masterfrom
tangenta:fix-split-corner-case

Conversation

@tangenta
Copy link
Contributor

@tangenta tangenta commented Nov 25, 2020

What problem does this PR solve?

Problem Summary:

create table t(a bigint(20) auto_increment primary key);
split table t between (-9223372036854775808) and (9223372036854775807) regions 16;

TiDB tries to calculate the splitting point with (max-min)/region_num. In the case above, the result is 0 and it violates the constraint(the step should be greater than 1000).

What is changed and how it works?

What's Changed:

  • Convert int64 to uint64 before calculating the split region step.
  • Refine the error message about splitting regions.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

N/A

Release note

  • Fix the issue that split table between large integers failed.

@tangenta tangenta requested a review from a team as a code owner November 25, 2020 06:20
@tangenta tangenta requested review from SunRunAway and removed request for a team November 25, 2020 06:20
@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Nov 25, 2020
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 24, 2021
AilinKid
AilinKid reviewed Mar 12, 2021
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

@AilinKid: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@AilinKid
Copy link
Contributor

AilinKid commented Mar 12, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2021
crazycs520
crazycs520 reviewed Mar 12, 2021
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

@crazycs520: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SunRunAway SunRunAway removed their request for review March 12, 2021 09:09
@crazycs520
Copy link
Contributor

crazycs520 commented Mar 12, 2021

/lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • crazycs520

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2021
@tangenta
Copy link
Contributor Author

tangenta commented Mar 12, 2021

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021
@tangenta
Copy link
Contributor Author

tangenta commented Mar 12, 2021

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021
@tangenta
Copy link
Contributor Author

tangenta commented Mar 15, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 45de1c3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2021

@tangenta: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 3641cd4 into pingcap:master Mar 15, 2021
This was referenced Mar 16, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AilinKid AilinKid AilinKid left review comments

@crazycs520 crazycs520 crazycs520 left review comments

Assignees

No one assigned

Labels

sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tangenta @ti-chi-bot @AilinKid @crazycs520