*: separate auto_increment ID allocator from _tidb_rowid allocator#20708
Closed
tangenta wants to merge 12 commits intopingcap:masterfrom
Closed
*: separate auto_increment ID allocator from _tidb_rowid allocator#20708tangenta wants to merge 12 commits intopingcap:masterfrom
tangenta wants to merge 12 commits intopingcap:masterfrom
Conversation
Closed
Contributor
Author
|
/run-all-test |
Member
|
@tangenta: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
Author
|
/hold because the need to design a complete test |
Contributor
Author
|
The new implementation is #28448. |
Merged
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #982
Problem Summary: before this PR, auto_increment ID and
_tidb_rowidshare the same key-value. The problem is any action that affectsauto_incrementcolumn also has an impact on_tidb_rowid. For example,The first insert statement forces auto_increment ID rebase to
9223372036854775807. Even if the second insert statement does not trigger auto_increment ID allocation, TiDB throws an "Failed to read" error because the_tidb_rowidallocator is exhausted.What is changed and how it works?
What's Changed:
TiDB behavior changes:
ALTER TABLE ... AUTO_INCREMENT = ?will not affect_tidb_rowidallocation anymore.@@auto_increment_incrementand@@auto_increment_offsetwill not affect_tidb_rowidallocation anymore.AUTO_ID_CACHEkeeps unchanged(AUTO_ID_CACHEstill affects_tidb_rowidallocation).Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note